PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.48k stars 13.5k forks source link

[Bug] Param metadata missing for json and xml files #23442

Closed hamishwillee closed 3 months ago

hamishwillee commented 3 months ago

Describe the bug

Generated .json and .xml files are missing parameters from the following groups (which are present in the generated .md metadata.

Geometry
ModalAI Custom Configuration
Payload Deliverer
RC
RC Input
Roboclaw
Roboclaw Driver
Rover Ackermann
Rover Differential Drive
Septentrio
UWB
UXRCE-DDS Client
Zenoh

To Reproduce

Run make parameters_metadata and inspect the output - you will note, for example, that all EKF group parameters are missing.

I generated this list by modifying px_process_params.py in each output to log the groups, then diffing

        print("XX Creating XML file " + args.xml)
        for group in param_groups:
            group_name=group.GetName()
            print(group_name)

Expected behavior

I'd expect all metadata to be exported. Note that in PX4 v1.14 timeframes EKF2 at least was included.

Screenshot / Media

No response

Flight Log

NA

Software Version

Tested on v1.14 (includes missing metadata for existing params), v1.15/main are missing the metadata

Flight controller

NA

Vehicle type

None

How are the different components wired up (including port information)

No response

Additional context

No response

hamishwillee commented 3 months ago

FYI @bkueng I'm using the json build to compare param changes between releases, which is how I noticed I was getting false positives in https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850

DronecodeBot commented 3 months ago

This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850/1