Open DonLakeFlyer opened 1 day ago
Also FYI: Although parameters theoretically support [u]int64's. QGCs px4 parameter metadata parsing code assumes 32 bits only for bit masks. That said switching to support 64 bits doesn't seem like a great idea since it's had zero testing. I don't think any current params are 64 bit.
@dagar Any reason bit masks can't be UINT32? That would fix the max problem.
A unit test which sanity checks the metadata would be nice so that this doesn't make it all the way to QGC before it's discovered. Look at https://github.com/mavlink/qgroundcontrol/blob/master/src/FirmwarePlugin/PX4/PX4ParameterMetaData.cc#L78 to see how QGC validates it for examples to test.
Describe the bug
Output from QGC says it all:
These parameters are INT32s. Note the metadata for max which is larger than an INT32.
And then for
VTQ_TELEM_IDS_2
:This is trying to set bits which are not available on an INT32.
Also since these are both bit mask parameters these should really be unsigned.
To Reproduce
Boot latest daily build QGC
Expected behavior
No response
Screenshot / Media
No response
Flight Log
No response
Software Version
No response
Flight controller
No response
Vehicle type
None
How are the different components wired up (including port information)
No response
Additional context
No response