Closed hamishwillee closed 7 years ago
The NAV_FORCE_VT parameter was not intended for RTL behavior, it was intended for accidental LAND instructions or manually switching to land mode.
The reason RTL forces this is people might want FW landings enabled but in an RTL event that doesnt always work. The behavior was indeed intended, perhaps it could be debated.
OK. Worth adding this clarification in the parameter doc ? E.g. FROM NAV_FORCE_VT - Force VTOL mode takeoff and land. TO NAV_FORCE_VT - Force VTOL for takeoff and land (but not RTL).
@dagar do you think RTL should honor NAV_FORCE_VT? or do we keep it hardcoded on land as MC?
I personally don't know any VTOL users that would even want/need NAV_FORCE_VT configurable. I think we should leave it as is, unless someone specifically asks for this behaviour.
I agree, @hamishwillee please update the docs
@dagar Can you update the parameter doc (if you think necessary) to
NAV_FORCE_VT - Force VTOL for takeoff and land (RTL always uses VTOL).
I'll fix up our other ones.
RTL will transition to MC regardless of the NAV_FORCE_VT parameter: https://github.com/PX4/Firmware/blob/master/src/modules/navigator/rtl.cpp#L326-L328
Not sure if this is intended or a bug - but either the implementation or docs need to be updated.