PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.22k stars 13.39k forks source link

vtol: thrust_min #7833

Closed Stifael closed 6 years ago

Stifael commented 7 years ago

Currently the Multi-copter land-detector relies on thrust values which represent the actual system thrust limits with some safety margin. The hover thrust and minimum thrust are used to determine if the vehicle is in a low thrust state (indication for demanding downward thrust: here ). In order to make the detection work as expected, it is desired that the hover thrust here is set as close as possible to the actual hover thrust, which is not necessarily 0.5. The minimum thrust (https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_params.c#L53) should also be set low. The larger the difference between low and hover, the better the land-detection will work.

I have learned that some vtols use large minimum thrust to keep the vehicle up during transition (please see comment here). The land detector is not really designed for that and there is no guarantee that a false-positive land-detection occurs if the minim thrust is large. The land-detection should be designed rather conservative to prevent any false-positive, otherwise we need to find a different solution for vtol.

To find a better solution than the current vtol state, I would like to discuss following points:

related issues and pr: https://github.com/PX4/Firmware/issues/7768 https://github.com/PX4/Firmware/pull/7772

LorenzMeier commented 7 years ago

@Stifael Let's discuss in person later this week. Manual thrust is used in the position controller: https://github.com/PX4/Firmware/blob/b620da8f01e66ec7653e367f86597629cac160e9/src/modules/mc_pos_control/mc_pos_control_main.cpp#L400

sanderux commented 7 years ago

have learned that some vtols use large minimum thrust to keep the vehicle up during transition Actually this is set to prevent loss of attitude when landing. Using pusher assist can cause a vtol to get lift from its wing when landing in a nose wind.

To counter this i have disabled pusher assist during autonomous landings but that does not fully mitigate the problem.

A proper VTOL land detector should likely be considering the following;

Stifael commented 7 years ago

@sanderux, I think that is straight forward to do in the vtol class. But nonetheless, I still would like to discuss the large minimum thrust value of 0.35, and even more if it is an attitude problem that you try to solve when demanding downward movement.

PX4BuildBot commented 6 years ago

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)