search

PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.53k stars 13.52k forks source link

RC sent to groundstation too slow #995

Closed julianoes closed 9 years ago

julianoes commented 10 years ago

The RC calibration is such a pain when the RC values only arrive at 1 Hz.

LorenzMeier commented 10 years ago

Stream rate config is implemented in QGC here: https://github.com/mavlink/qgroundcontrol/blob/master/src/uas/UAS.cc#L2274

But just for the one stream (and in the old stream notion). If you re-implement this with two parameters stream id, rate:

You could add this as function to the UAS object, analog to this (check also UASInterface.h, where you need to define the function in addition to UAS.h): https://github.com/mavlink/qgroundcontrol/blob/master/src/uas/UAS.cc#L1667

And then finally add it here and here: https://github.com/mavlink/qgroundcontrol/blob/master/src/ui/QGCPX4VehicleConfig.cc#L527 https://github.com/mavlink/qgroundcontrol/blob/master/src/ui/QGCPX4VehicleConfig.cc#L668

And merge this branch: https://github.com/PX4/Firmware/pull/812

Then you could have 50 Hz during the calibration while not deteriorate everything during flight 8).

@DrTon You're invited to chime in here too if you like.

LorenzMeier commented 10 years ago

Note: The ID you want to use is that of the RC channels raw packet

DrTon commented 10 years ago

The RC calibration is such a pain when the RC values only arrive at 1 Hz.

Do it using USB :) Flooding slow telemetry link with RC control messages is not good idea IMO. But as @LorenzMeier said, you can increase rate while calibrating.

julianoes commented 10 years ago

BUMP, has this been added yet?

DrTon commented 10 years ago

No. Welcome to do qgc side, then I can help with autopilot side :)

LorenzMeier commented 10 years ago

@julianoes There is an API to set the stream rates per message, and the RC widget should execute that. @DonLakeFlyer This is likely something for you.

DonLakeFlyer commented 10 years ago

I just made the RC Widget visible again a few days back. No idea if it works. If it did before, it should still work. It’s part of the Onboard Parameters tool. Not exactly sure how it’s supposed to work. You may need to look at the code.

On Nov 11, 2014, at 10:08 PM, Lorenz Meier notifications@github.com wrote:

@julianoes https://github.com/julianoes There is an API to set the stream rates per message, and the RC widget should execute that. @DonLakeFlyer https://github.com/DonLakeFlyer This is likely something for you.

— Reply to this email directly or view it on GitHub https://github.com/PX4/Firmware/issues/995#issuecomment-62683222.

LorenzMeier commented 9 years ago

Closing this on the Firmware side. Support is here: https://github.com/PX4/Firmware/blob/master/src/modules/mavlink/mavlink_receiver.cpp#L1107-L1122