Update Readme for Ubuntu 20.04 and fix PX4 changes

PX4 / PX4-Avoidance

PX4 avoidance ROS node for obstacle detection and avoidance.

http://px4.io

BSD 3-Clause "New" or "Revised" License

635 stars 330 forks source link

Update Readme for Ubuntu 20.04 and fix PX4 changes #692

Closed jhiggason closed 1 year ago

jhiggason commented 1 year ago

While trying to get a working simulator going- I found that the only way to do so with the current packages available was to switch to Ubuntu 20.04 and ROS Noetic. I also updated the new path for setup_gazebo.bash and changed some of the instructions to more match what is on ROS Noetic's install page.

I've only ever been able to get this working on a desktop version of 20.04- For whatever reason- virtual machines are not functioning the same. Once i figure that portion out I will make notes in the readme on how to make a virtual machine work.

julianoes commented 1 year ago

FYI @baumanta

Jaeyoung-Lim commented 1 year ago

@nicovanduijn Actually we already are testing against ROS Noetic :smile: : https://github.com/PX4/PX4-Avoidance/blob/79c2f3b28b6ae48fdbedc46eebaeea043b12e556/.github/workflows/build_test.yml#L18

So I believe the only missing part was really the instructions

nicovanduijn commented 1 year ago

@Jaeyoung-Lim not everywhere, right? I guess what's broken is this: https://github.com/PX4/PX4-Avoidance/blob/79c2f3b28b6ae48fdbedc46eebaeea043b12e556/.github/workflows/valgrind_test.yml#L17

Jaeyoung-Lim commented 1 year ago

@nicovanduijn I think the Valgrind tests were supposed to be ros distribution agnostic - As far as I remember, this is why not even melodic was being tested there.