search

PX4 / PX4-Flow

Firmware for PX4FLOW board
236 stars 340 forks source link

Fix #98 & code maintenance #123

Closed mike239x closed 4 years ago

mike239x commented 4 years ago

A few small changes aimed to improve the code.

tpetri commented 4 years ago

Cool! I wanted to fix subdirs/mindir thing since one year, found no time.

Is the histogram filter currently in active use by anyone? I could image that suddenly the filtered values start to make sense after this fix ;) I'm not actively using the flow sensor anymore.

mike239x commented 4 years ago

Mmmm, I don't know if anyone uses histogram filter rn, it is off by default and I decided to not touch that yet - I still need to read through the corresponding part of the code :) I will revert the comments that you mentioned to how they were and update this :+1:

mike239x commented 4 years ago

:man_facepalming: I should not have made PR out of my master branch, gonna make a new one. Sorry for that.

tpetri commented 4 years ago

The bug only concerns the histogram as far as I can see, that might be reason why no one cared or noticed it for so long, anyways, good to have it fixed :+1: