search

PX4 / PX4-SITL_gazebo-classic

Set of plugins, models and worlds to use with OSRF Gazebo Simulator in SITL and HITL.
http://dev.px4.io/simulation-gazebo.html
368 stars 786 forks source link

Check magnetic table readout #321

Open CarlOlsson opened 5 years ago

CarlOlsson commented 5 years ago

There was a bug in ECL regarding the readout of the magnetic tables sometimes resulting in a large error in magnetic declination and inclination. We need to check that the same error is not present in SITL

Jaeyoung-Lim commented 4 years ago

@CarlOlsson Any updates regarding this issue?

CarlOlsson commented 4 years ago

No, I think we should use the same library for calculating the magnetic field in ECL and SITL. I.e. moving the ecl geo functionality to its own submodule and also include that in SITL would probably be the best

dagar commented 4 years ago

It's perhaps a bit convoluted, but you could include ecl in sitl_gazebo and use only the ecl_geo library.

CarlOlsson commented 4 years ago

either that or include ecl_geo in ecl and sitl_gazebo, which one do you prefer?

TSC21 commented 4 years ago

I do prefer the approach of bringing ecl_geo to its own submodule and probably rename it, so it becomes agnostic for both sitl_gazebo and ecl.

LorenzMeier commented 3 years ago

@Jaeyoung-Lim Could you have a look?