search

PX4 / PX4-gazebo-models

Model repo in app.gazebosim.org
BSD 3-Clause "New" or "Revised" License
11 stars 35 forks source link

Added IMU sensor noise to the model, to avoid STALE messages #34

Closed slgrobotics closed 4 months ago

slgrobotics commented 4 months ago

This is direct following of the https://github.com/PX4/PX4-gazebo-models/pull/33

@PerFrivik @frede791 @dagar I don't see a reason for the lawnmower IMU to be different from R1 Rover settings, so I just copied those.

Maybe, vibrations from the gas engine could be accounted in the future revisions. I am not good with these numbers, any clues?

I'd be more interested in adding better precision to NavSat sensor, emulating RTK 1.5 cm accuracy. Any suggestions?

BTW, if anybody is still interested in "two space indentation/tabs for SDF" - I can fix it here for all models, I have a tool (XML Copy Editor https://sourceforge.net/projects/xml-copy-editor/ - it does "XML->pretty print" very well). ;-) - @bperseghetti

frede791 commented 4 months ago

LGTM

dagar commented 4 months ago

BTW, if anybody is still interested in "two space indentation/tabs for SDF" - I can fix it here for all models, I have a tool (XML Copy Editor https://sourceforge.net/projects/xml-copy-editor/ - it does "XML->pretty print" very well). ;-) - @bperseghetti

If we can enforce code style with a tool (and otherwise never have to talk it) I'm all for it.