search

PX4 / PX4-user_guide

PX4 User Guide
https://docs.px4.io/main/en/index.html
Other
283 stars 1.56k forks source link

Add VectorNav driver documentation #3191

Closed lashVN closed 1 month ago

lashVN commented 2 months ago

Tidy up work:

lashVN commented 2 months ago

3183

hamishwillee commented 2 months ago

@lashVN A few more comments added. YOu might have to chase up Daniel more directly on the published topics. I'd be OK to merge without those links.

lashVN commented 2 months ago

@hamishwillee

I just added a few deltas correcting some of the information and adding a link to our ICD. WHen you say

Fix link to docs in https://docs.px4.io/main/en/modules/modules_driver_ins.html#examples Are you referring to this link:

Setup/usage information: https://docs.px4.io/master/en/sensor/vectornav.html

I'd thought this wouldn't need to be updated, given this file is in that new location. Am I missing something?

Concerning the external_ins... UOrb topics, those are only conditionally available so don't show up in the messages folder, so I don't think we can generate a link for them.

I'm good with merging this in. Is there aything else you're waiting from me, or can you merge it in?

hamishwillee commented 2 months ago

I'd thought this wouldn't need to be updated, given this file is in that new location. Am I missing something?

Yes, they aren't at the same location. See "main" vs "master".

I'll have a look at this on Weds, and hopefully merge!

@bkueng is there any way to force docs for these "conditional" UORB topics to be built?

lashVN commented 1 month ago

Hi @hamishwillee , any update on merging in this pr?

hamishwillee commented 1 month ago

@lashVN Thanks very much. Your fixes good. I did a little further tidying. Let's get this in and we can iterate if needed.

github-actions[bot] commented 1 month ago

No flaws found