hamishwillee
commented
4 months ago @julianoes I've finished this round of update and I plan to merge. Would love a follow on sanity update if you have time.
This is now split into four camera docs - the two mavlink protocols and the FC connected have hardware setup/usage guides. There is also a "camera architecture/integration" doc. The first ones are pretty much - if you have this camera this is what you do, while the integration one explains how it works, and points to some code (the stuff you helped me find).
We don't perhaps need the integration one, but given how long it took to work out how it all works, this might same some time next time.
Some interesting points:
- MAVLink camera protocol 2 trigger events are not logged in PX4, so you can't use QGC geotagging. PX4 should log incoming CAMERA_CAPTURE_INFO messages if we want to support this using the same mechanism.
- Camera logging is a little broken, in that every capture is logged, not just the "most relevant": https://github.com/PX4/PX4-Autopilot/pull/23103
- The MAVLink 1 camera integration doesn't strictly need camera trigger etc - that essentially just provides logging for this particular type of camera. You could send commands direct to the camera. It was this way almost certainly because then you can just always send commands to the autopilot for both FC and old-Mavlink cameras.
github-actions[bot]
This splits out MAVLink cameras and FC-connected cameras into their own documents. Their setup is quite different, and the current story is unclear.
This fell out of the discussion here: https://discuss.px4.io/t/connect-siyi-camera-module-to-px4/37782/3