search

PX4 / PX4-windows-toolchain

Repo containing all scripts to install and use the PX4 Toolchain for Windows.
BSD 3-Clause "New" or "Revised" License
31 stars 100 forks source link

v0.7 additional steps before building #17

Open TheSoundMan000 opened 4 years ago

TheSoundMan000 commented 4 years ago

Installation of 0.7 failed to build without installing packaging and pyros-genmsg. Unsure if these are the expected versions so hoping to get this fixed up in the installer to remove any potential issues. Note that pip3 was deliberately not updated to keep in line with the default environment.

pip3 install packaging pip3 install --user pyros-genmsg

The only thing to note is there was a prior installation of 0.5.

hamishwillee commented 4 years ago

This is the Cygwin installation? Delete the PX4 folder and install the latest version - 0.9

TheSoundMan000 commented 4 years ago

Does 0.9 work with 1.10? Another user had indicated to only use the versions given in the documentation https://dev.px4.io/v1.10/en/setup/dev_env_windows_cygwin.html which points to 0.7. Perhaps a good idea to update the documentation if this is the case so newbies like myself don't get caught out.

A fresh install on another PC has the same results unfortunately.

TSC21 commented 4 years ago

Does 0.9 work with 1.10? Another user had indicated to only use the versions given in the documentation https://dev.px4.io/v1.10/en/setup/dev_env_windows_cygwin.html which points to 0.7. Perhaps a good idea to update the documentation if this is the case so newbies like myself don't get caught out.

A fresh install on another PC has the same results unfortunately.

Yes it does work with 1.10.

hamishwillee commented 4 years ago

@TheSoundMan000 That's a good point. The answer being "Probably". IMO you'd be best of trying v0.8 because I am pretty sure that works with v1.10. Otherwise you can wait until @MaEtUgR looks at this :-)

TheSoundMan000 commented 4 years ago

Awesome thanks guys, appreciate your help!

Happy to switch versions for now that's easy enough, just curious then is it safe to use the patch I put in place or does that leave the potential for incorrect versions etc?

hamishwillee commented 4 years ago

I don't know what you mean by "patch you put in place". But my understanding is that everything lives in the PX4 folder - it is a complete environment. So if you delete/recreate that, the patch is gone.

MaEtUgR commented 4 years ago

@TheSoundMan000 Sorry for any confusion. To work on latest PX4 master you can just use toolchain v0.9 but it might give you some small problems on PX4 v1.10.1 SITL probably because Cygwin updated the compiler. Your patch of adding the missing python packages to build latest master are perfectly fine, that's exactly what the additional versions were triggered for. I added more release notes to hopefully clear things up: https://github.com/PX4/windows-toolchain/releases

For your reference the changes you did manually are in the automatic script to generate the new versions here: https://github.com/PX4/windows-toolchain/commit/8f8fbb42052a3718429534a7ee8f2965277dee52, https://github.com/PX4/windows-toolchain/commit/15130617f98d404d30be2fa5004a4df6894085d7