search

PX4 / flight_review

web application for flight log analysis & review
https://logs.px4.io/
BSD 3-Clause "New" or "Revised" License
195 stars 191 forks source link

Automate image build for docker-compose #206

Open bbworld1 opened 3 years ago

bbworld1 commented 3 years ago

The px4flightreview image does not exist until you build it manually, meaning the docker-compose config will not launch until you build the Dockerfile. Combined with a relative lack of documentation, this leads to user confusion.

It would be best to add a build: section in the docker-compose configuration, which will automatically build and tag the image when the configuration is run.

Side note: have we considered pushing an actual official px4flightreview image to Docker Hub? It may be useful to have.

bkueng commented 3 years ago

Hi Feel free to suggest any changes you'd like to see via PR. Personally I don't use docker for this.

bbworld1 commented 3 years ago

Thanks, I've added it at #207 here.

Docker Hub pushes are trivial to automate now that docker-compose handles building (simply docker-compose build, then docker-compose push), if that's an option you want to explore.