search

PX4 / flight_review

web application for flight log analysis & review
https://logs.px4.io/
BSD 3-Clause "New" or "Revised" License
193 stars 190 forks source link

Tailsitter attitude correction #241

Closed amandastowers closed 2 years ago

amandastowers commented 2 years ago

Hi, I have added some logic to do orientation conversion on attitude for tailsitters in fixed wing mode. Before this logic, tailsitters would appear very unable to track attitude trajectories in fixed wing mode. Now flight review can correctly display the tailsitter attitudes. See attached images for before and after. newpitch newroll oldpitch oldroll

bkueng commented 2 years ago

Thanks for looking into this. I'm a bit surprised to see the FC does not publish a consistent attitude + setpoint. Instead of adding custom logic in here, we should make sure the data is published consistently. I had a quick chat with @sfuhrer and he anyway wants to do that.

amandastowers commented 2 years ago

Changes requested by @bkueng incorporated.

amandastowers commented 2 years ago

OK, think everything above should be corrected now.

amandastowers commented 2 years ago

Should be resolved now