search

PX4 / flight_review

web application for flight log analysis & review
https://logs.px4.io/
BSD 3-Clause "New" or "Revised" License
193 stars 190 forks source link

QGC Parameters #265

Closed afwilkin closed 8 months ago

afwilkin commented 9 months ago

When you want to download a parameter file... it can not be directly uploaded into QGC. This givces you the option to download the QGC compatible one. This PR was based off of @farhangnaderi PR here: #264

afwilkin commented 9 months ago

@bkueng let me know if there is any changes you would like me to make

farhangnaderi commented 9 months ago

Thanks Andrew! I appreciate it!

afwilkin commented 9 months ago

Apologies Beat, I did not see you had reviewed this. I will fix these

afwilkin commented 9 months ago

@bkueng I addressed your comments. I know you mentioned there are some CI problems that we will incur. Mainly the long method. what is the method length that will pass the CICD test so I know how to modify the code?

bkueng commented 9 months ago

I needed to approve so the checks are running. They're queued now and should run shortly. This is from a previous run: https://github.com/PX4/flight_review/actions/runs/6726581710/job/18290754736#step:5:14. You can run the checks locally with ./run_pylint.sh

afwilkin commented 8 months ago

@bkueng made changes.

Also added something to the bottom of the readme to let others know to run ./run_pylint before making PR to help with CICD.