Closed ciresimo closed 2 months ago
@sfuhrer can you give some feedback on this?
@sfuhrer please let us know if this is true. the rates for roll, pitch and yaw don't make sense
Makes total sense to also transform the rate setpoints and not only the rate measurements from the body to the "fixed-wing" frame :+1:
I think I had some problems with pyulog. I rebased and now seems to be fine I ran the test locally and got 10
I was analysing some logs for a quadtailsitter without control surfaces that i'm developing, and I notice that even though the angle tracking of roll was quite good, the plots for the rates did not make sense
![rollrate_wrong](https://github.com/PX4/flight_review/assets/149970685/ba32ca13-224a-410c-bd83-36e9799a9d32)
Here the complete logs for reference By looking into the
configured_plots.py
I saw that if the vehicle is a tailsitter angles and rates are reassigned to be plotted in a more consisten way for the instants that drone is flying in fixed wing:but this is not applied to the rates setpoint, so the result is that on the rollrate plot , for example , the data shown are:
What I did was simply remapping also the setpoints in fixed wing so to have in the same plot
Tracking is still not perfect, but that's a problem with the simluation. Aslo plot of yaw rate makes more sense:
Old![yawrate_wrong](https://github.com/PX4/flight_review/assets/149970685/f242ee86-3e7a-4709-a6e8-ad53bf0323ec)
New![yawrate_new](https://github.com/PX4/flight_review/assets/149970685/d83ca927-09cc-4593-8a49-474cf0bfa973)
Honestly this to me was very confusing, since I tried to find a reason for the behavior of correct angles but completely wrong rate control. In this way it makes more sense, so you could easily see if the rate controller is good at tracking. I think this was the way it was handled in the past, since I saw some old logs review that did not have this problem and I think is related on the new control approach. I'm conscious that the code may need other adjustments, since probably I'm not considering some cases (did not look into PID analysis for now). I opened this PR just to understand if this was actually a problem or the was a specific reason for this