trying again to update jmavlib

PX4 / jMAVSim

Simple multirotor simulator with MAVLink protocol support

BSD 3-Clause "New" or "Revised" License

82 stars 207 forks source link

trying again to update jmavlib #51

Closed lovettchris closed 6 years ago

lovettchris commented 7 years ago

sigh... how did the BOM com back ? I have one more idea....

LorenzMeier commented 7 years ago

Hey, what's missing here in feedback from me?

lovettchris commented 7 years ago

One of the files I changed has a Unicode byte order mark at the top of the file (0xFF FE) and apparently your build system can't handle that kind of byte order mark. But when I remove this in a branch and try and do a pull request "git" decides NOT to remove the byte order mark in the master branch. So I believe this will require someone manually merging the bits and removing the byte order mark before committing to the master branch. See https://en.wikipedia.org/wiki/Byte_order_mark.

julianoes commented 6 years ago

Replaced by #65, closing.