search

PX4 / jMAVSim

Simple multirotor simulator with MAVLink protocol support
BSD 3-Clause "New" or "Revised" License
82 stars 207 forks source link

sensor noise parameter control dialog #66

Closed stmoon closed 6 years ago

stmoon commented 6 years ago

I implemented the sensor noise parameter control dialog for flight test and analysis.

https://youtu.be/5V67fofzN9s

The idea was inspired by @hamishwillee while add random walk noise for gps in this simulation. (refer to https://github.com/PX4/jMAVSim/pull/64)

I hope that it is useful to analyze and understand the px4 control code.

please check it @bkueng and @TSC21

Thanks in advance.

SungTae Moon

TSC21 commented 6 years ago

@stmoon is there any way you could actually integrate this with the UI of jMAVSim, instead of having a new window for it?

stmoon commented 6 years ago

@TSC21 If you think it is better than now, I will try it again.

TSC21 commented 6 years ago

I think it will look better but if it is too much work you don't have to spend time on it. As is, is more than enough.

stmoon commented 6 years ago

Thanks @TSC21

Actually, I think it spend some time. How about using the current version ? (However I will have plan to insert the dialog to main UI for next time)

TSC21 commented 6 years ago

Let's wait for @bkueng review.

stmoon commented 6 years ago

Thanks @TSC21

stmoon commented 6 years ago

Based on advice of @TSC21, I integrated the sensor parameter control panel with the main UI of jMAVSim (not dialog)

the shortcut key is same ('d' key)

Thanks for your advice of @TSC21 ;-)

TSC21 commented 6 years ago

@stmoon can you share us a new video with it working? Thanks

stmoon commented 6 years ago

please check the video

https://youtu.be/e3Tppt9nteM

Thanks.

stmoon commented 6 years ago

@bkueng, please check it

stmoon commented 6 years ago

Hi, @bkueng

I merged the updated master.

Could you check the modified codes? I want to go to the next step.

Thanks.

stmoon commented 6 years ago

I'm analyzing the unnecessary compile step which you say. It will need some time to check it...

stmoon commented 6 years ago

Hi, @bkueng

It seems to be due to intellij javac2. (The problem is happened when flightplot is compiled)

Unfortunately, I didn't find the solution to remove the warning message until now,

If it is not critical to merge it, how about merging it first?

Of course, I will try to find the solution.

bkueng commented 6 years ago

Ok, I'm merging this, but maybe we should remove the javac2 again, and replacing the forms file with something else?

stmoon commented 6 years ago

Thanks @bkueng ,

Good idea!!

I will remove javac2 and use javac again!!

Thanks!!