search

PX4 / px4_msgs

ROS/ROS2 messages that match the uORB messages counterparts on the PX4 Firmware
http://px4.io
BSD 3-Clause "New" or "Revised" License
68 stars 123 forks source link

fixed vtol vehicle status #23

Closed drasgo closed 1 year ago

drasgo commented 1 year ago

fixed vtol vehicle status to be consistent with what is being published by px4 firmware at the stable version 1.13.2

drasgo commented 1 year ago

The reason for this pull request is that in the latest stable release of PX4 Autopilot (1.13.2 https://github.com/PX4/PX4-Autopilot/tree/v1.13.2 ) some messages are inconsistent with the messages present in this repo. I understand this is not the proper solution and that there is an automated bot that automatically updates the messages here to mirror the messages in PX4, but this is true only for the main branch, and not for the stable releases, so I would suggest to setup up another automated bot that would create a branch for each of the stable releases, mirroring the actual messages' templates fo the specifc stable releases. The only branch I saw here maybe doing this is release/1.13, but it is I am not sure to which sub-release this points to. Regarding this pull request, it is mainly here to have a commit to use for pulling a more accurate representation of the stable version messages' templates of the stable release 1.13.2.

hamishwillee commented 1 year ago

PX4_msgs needs to be consistent with the associated release branch in order to allow PX4 and ROS to interwork. If you're working on PX4 main then these messages need to match the ones in the PX4 main branch. If you're working in PX4 v1.13 then the messages need to match the ones in the https://github.com/PX4/px4_msgs/tree/release/1.13 branch.

It is OK for PX4 v1.13 and PX4 main to diverge.

So this is invalid, and you should be using https://github.com/PX4/px4_msgs/tree/release/1.13

What docs pointed you to use the main branch? They might be broken.

hamishwillee commented 1 year ago

FYI @beniaminopozzan That's right isn't it ^^^^ ?

PS @drasgo CI is supposed to automatically copy the messages across from PX4-Autopilot main, so even if you do this, it will get swamped by the next updates.

beniaminopozzan commented 1 year ago

@hamishwillee thanks! Yes, that is correct!

@drasgo , all the 1.13.x tags have the same message definitions as the .xs are patches, major bugfix or new boards support.

The only branch I saw here maybe doing this is release/1.13, but it is I am not sure to which sub-release this points to.

So, you can use release/1.13 of this repo with any 1.13.x of PX4-Autopilot

drasgo commented 1 year ago

Ah thank you! I'll use the release/1.13 tag then, cheers!