PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

Tutorial nano crystal diffraction geometry Parameter not set #159

Closed belfhi closed 6 years ago

belfhi commented 6 years ago

CrystFELPhotonDiffractorParameters does not set geometry in constructor.

n01r commented 6 years ago
parameters = CrystFELPhotonDiffractorParameters(
     ...
    detector_geometry='simple.geom',    # External file that contains the detector geometry in CrystFEL notation.
    )

Apparently the tutorial was wrong because it used the keyword geometry but the class constructor requires detector_geometry. Strangely we got not error from using an unknown keyword.