search

PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

BaseCalculator: call saveH5() when running from CLI #160

Closed codingS3b closed 6 years ago

codingS3b commented 6 years ago

When running a calculator from the command line it would make sense that the saveH5() interface function would be called after the backengine() call has finished to ensure that the file formats are correct and one would not need to go back to the python objects to call this manually.

codingS3b commented 6 years ago

I searched the project for calls to saveH5 and from what I saw it only came up as function definitions or in test files. The only other occurence was in PhotonExperimentSimulation.run() but this is not inheriting from the calculator classes so we should be safe there as well (I hope).

CFGrote commented 6 years ago

ok, i merged