Review gapd calculator

[CFGrote]

Hi Juncheng, very good work, just a few minor comments:

GAPDPhotonDiffractorParameters.py:

• [ ] l 4ff: put yourself as 2nd author
• [ ] l 37ff: check you really need all these parameters, do they make sense for GAPD?
• [ ] 102-115: as discussed: remove these lines, align 116-126

GAPDPhotonDiffractorTest.py

• [ ] l4f: add yourself as 2nd author

GAPDPhotonDiffractorParametersTest.py

• [ ] l4f: add yourself as 2nd author

So far so good. I assume you will work on the GAPDPhotonDiffractor next?

[CFGrote]

hi @ejcjason , any progress on this one?

[JunCEEE]

I am overwhelmed by the EMC analysis. I will finalize this on the weekend.

[JunCEEE]

• [ ] Monochromatic beam unittest
• [ ] Polychromatic beam unittest
• [ ] Temporal integration unitest
• [ ] Read PMI output unittest
• [ ] CXI hdf5 output unittest