search

PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

Neutrontools #194

Closed leczzsolt closed 4 years ago

leczzsolt commented 4 years ago

New files are added: IonMatterInteractorParameters.py AbstractIonInteractor.py TNSAIonMatterInteractor.py

CFGrote commented 4 years ago

hi zsolt, may i ask you to make a new PR with develop as target branch? i would like to gain more experience with this before making it an official part of the master branch? thanks!

CFGrote commented 4 years ago

the code looks good. do you think you could add some tests? ask @ejcjason for help. I'll be happy to merge into develop once the checks go through.