search

PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

Neutrontools #201

Closed leczzsolt closed 4 years ago

leczzsolt commented 4 years ago

I included some tests. Probably the source data file (sdf) is also needed for running the tests...

leczzsolt commented 4 years ago

Hi Carsten ! Can you resolve the conflict in the readme file? After that it can be merged into the develop branch.

CFGrote commented 4 years ago

$> echo SDF >> requirements.txt

-- Dr. Carsten Fortmann-Grote PaNOSC WP5 leader

On 5/18/20 3:12 PM, Juncheng E wrote:

@ejcjason commented on this pull request.

In Sources/python/SimEx/Calculators/TNSAIonMatterInteractor.py https://github.com/PaNOSC-ViNYL/SimEx/pull/201#discussion_r426614748:

@@ -0,0 +1,163 @@ +from SimEx.Calculators.AbstractIonInteractor import AbstractIonInteractor +import sdf

To solve the problem, the environment for |sdf| should be set for the Travis environment, @CFGrote https://github.com/CFGrote do you know how to do it?

Hi @leczzsolt https://github.com/leczzsolt, I just noticed that you merged the branch without passing the test. The problem doesn't seem really solved. @CFGrote https://github.com/CFGrote , I think we should pass the test before merging? Could you revert the merging?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PaNOSC-ViNYL/SimEx/pull/201#discussion_r426614748, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADWCQR3AN6UTHHSTQ3N7D73RSEX3LANCNFSM4NAWOAZQ.