PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

simex doesn't check if crystfel is installed #238

Closed kirienko closed 3 years ago

kirienko commented 3 years ago

The install.sh script always tries to install CrystFEL regardless of it's actual status. Even if I already have crystfel installed, the installation script tries to do the same. It wouldn't be a problem if the script is capable of doing the proper installation. But usually it fails. (And even funnier that if I just call the same make && sudo make install command on my own, it works.)

All in all, it'd make the SimEx installation process much easier, if the installation script check whether the binaries needed are already accessible (say, with which render_hkl or whatever it needs).