search

PaNOSC-ViNYL / SimEx

Start-to-end photon experiment simulation platform
https://simex.readthedocs.io/
GNU General Public License v3.0
26 stars 25 forks source link

check if CrystFEL software is installed #240

Closed kirienko closed 3 years ago

kirienko commented 3 years ago

The purpose of this change is to check if CrystFEL software package is already installed. In this case the SimEx installer will just safely skip this step. This may save user from the confusion that crystfel is installed but SimEx not only fails to recognize that fact but also fails to [re]install on its own.

make looks for the hdfsee command and if it is in the $PATH it understands crystfel is installed. I admit that there might be a better way to check. I'll be delighted to see one.

Close #238

kirienko commented 3 years ago

@JunCEEE

JunCEEE commented 3 years ago

Hi @kirienko, I just noticed that if CrystFEL is not installed, the CMake process to install CrystFEL by SIMEX cannot get started because of the following error:

-- ***** Including module CrystFELPhotonDiffractor from: Diffractors/CrystFELPhotonDiffractor ****
CMake Error at Modules/Diffractors/CrystFELPhotonDiffractor/CMakeLists.txt:1 (find_program):
  Could not find HAVE_CRYSTFEL using the following names: hdfsee

Could we check the installation of CrystFEL without throwing the error?