search

PaNOSC-ViNYL / ViNYL-project

This repository keeps track of tasks, milestones, deliverables of workpackage 5 in panosc.
Apache License 2.0
5 stars 5 forks source link

discussed libpyvinyl updates #78

Closed mads-bertelsen closed 2 years ago

mads-bertelsen commented 2 years ago

Small updates to libpyvinyl to streamline design.

  1. Use property where setters and getters should be mandatory (primarily value)
  2. Streamline method names, lowercase underscore and full words
  3. Use ordered dict to ensure parameters are printed in reasonable order
mads-bertelsen commented 2 years ago

Pull request that includes 1. and 2. here: https://github.com/PaNOSC-ViNYL/libpyvinyl/pull/29, just needs a quick review.

mads-bertelsen commented 2 years ago

The pull request was made on master, and it should have been on develop. The changes were implemented in the numpy branch, so they will be included there. We still have to work on the method names though.

mads-bertelsen commented 2 years ago

Point 1. and 3. have been merged into develop under the numpy. Still need to go through method names, which should be done on a new branch and will obviously be a breaking change for any package that depend on libpyvinyl.

mads-bertelsen commented 2 years ago

The changes were merged in these two pull requests: https://github.com/PaNOSC-ViNYL/libpyvinyl/pull/28 https://github.com/PaNOSC-ViNYL/libpyvinyl/pull/35