search

PaackEng / elm-ui-dropdown

Dropdown module for Elm UI
https://package.elm-lang.org/packages/PaackEng/elm-ui-dropdown/latest/
MIT License
20 stars 11 forks source link

Simplify example3 😅 #10

Closed kutyel closed 4 years ago

kutyel commented 4 years ago

This is somewhat related to #9

If you checkout the code, the example works exactly as before.

But the previous code led me to think that explicit handling of the open dropdowns (when there are many) needs to be done, this is not true, since from the moment that you give each individual dropdown its own state, they are responsible to be closed or opened for themselves.

No one was triggering the Toggle event and that seemed suspicious 😅

PedroHLC commented 4 years ago

@kutyel could you rebase this one?

kutyel commented 4 years ago

@kutyel could you rebase this one?

Sure, done! ✅ and thanks for merging all my PRs! ❤️

PedroHLC commented 4 years ago

Sure, done! white_check_mark and thanks for merging all my PRs! heart

No worries, collaborations are welcomed!

I've published it to: https://package.elm-lang.org/packages/PaackEng/elm-ui-dropdown/1.2.0

Looks like elm packages require absolute-path for images. :sweat_smile:

Anyway, thanks for your contribution, from PaackEng and the open-source community! :partying_face: