PaackEng / elm-ui-dropdown

Dropdown module for Elm UI
https://package.elm-lang.org/packages/PaackEng/elm-ui-dropdown/latest/
MIT License
20 stars 11 forks source link

Initialising dropdown's selected item to a default item #23

Closed rachel-barrett closed 3 years ago

rachel-barrett commented 3 years ago

Hi,

I haven't been able to find a way to initialize the dropdown to a default value. Is this something that can be added, and a feature anyone else would be interested in?

Rachel

jouderianjr commented 3 years ago

Hello @rachel-barrett, unfortunately, we currently do not provide this feature, but it totally makes sense to add it. Is this something you would like to make a pr or something like that?

Many thanks for the feedback

rachel-barrett commented 3 years ago

Hi @jouderianjr. Thanks for your message. Ok great, Iā€™m happy to have a go at a pr for this. It would be my first time contributing to open source - do I have to think about whether the pr involves breaking changes and therefore what the version bump should be etc? How does a release get triggered? Thanks, Rachel

rachel-barrett commented 3 years ago

Created a pull request for this issue here https://github.com/PaackEng/elm-ui-dropdown/pull/24

jouderianjr commented 3 years ago

Hey @rachel-barrett many thanks for the pull request, I will check it out this weekend ok? šŸŽ‰

rachel-barrett commented 3 years ago

Thanks!

jouderianjr commented 3 years ago

So before release a new version I would prefer for the options argument the same you did in the selected option, but for sure this will come in the upcoming days, many thanks for the contribution @rachel-barrett šŸŽ‰

rachel-barrett commented 3 years ago

No problem, thanks also for your reviews! Totally makes sense to make sure the api is right for the next release. Since it's related to my change and a quick change, I'm happy to create a follow up PR for the change to the options argument probably sometime this week... if that would help?

jouderianjr commented 3 years ago

@rachel-barrett it will be great, I really appreciate šŸ‘ šŸ‘ Many thanks for the hard work