PaackEng / elm-ui-dropdown

Dropdown module for Elm UI

https://package.elm-lang.org/packages/PaackEng/elm-ui-dropdown/latest/

MIT License

20 stars 10 forks source link

Get rid of NoOp #37

Closed PedroHLC closed 3 years ago

PedroHLC commented 3 years ago

:thinking: What?

Drops the usage of NoOp, stopPropagation and preventDefault.

:man_shrugging: Why?

Remove useless triggers to update;
I wanted to test if this solved some issues I had, but it didn't.

:pushpin: Jira Issue

Not tracked.

:no_good: Blocked by

35

:clipboard: Pending

Nothing.

fmechant commented 3 years ago

I am glad you changed NoOp. A good practice is to have a message reflect what happened, not what has to be done.