search

Pablissimo / SonarTsPlugin

SonarQube plugin for TypeScript files
MIT License
185 stars 105 forks source link

Fixing scenario with multiple "!"s in the LCOV path. #100

Closed TonD83 closed 7 years ago

TonD83 commented 7 years ago

We have SF lines in the LCOV files generated by angular cli looking like:

SF:/Users/xxx/xxx/xxxxx/yyyy/app/node_modules/angular2-template-loader/index.js!/Users/xxx/xxx/xxxxx/yyyy/app/node_modules/tslint-loader/index.js!/Users/xxx/xxx/xxxxx/yyyy/app/src/app/questions/loader.ts

So looking at the part of the path after the first ! won't solve our problem, however looking at part of the path after the final ! would.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 92.742% when pulling 9e6ce7196f8fe36bd28ec96ba27d7d8ce7d4924c on TonD83:fix-lcov-path into a2b382da0a7424c9861da2750b40f332543314eb on Pablissimo:master.

Pablissimo commented 7 years ago

I knew when I put that in it'd come back to bite me! Will merge at the weekend, thanks for the PR!