search

Pablissimo / SonarTsPlugin

SonarQube plugin for TypeScript files
MIT License
185 stars 106 forks source link

Rules from tslint.json are not applied #185

Open damodhar22 opened 6 years ago

damodhar22 commented 6 years ago

I disabled all the 123 rules in sonar qube. Added only one rule in tslint.json. When I ran the sonar, no issues are shown even though code has the issues(it's using magic numbers which violates the tslint rule below).

Why plugin not picking rules from tslint.json??

tslint.json { "rules": { "no-magic-numbers": true } }

sonar tsplugin properties property "sonar.projectName", "ABC" property "sonar.sourceEncoding", "UTF-8" property "sonar.sources", "src" property "sonar.language", "ts" property "sonar.exclusions", ["node_modules/**"] property "sonar.ts.coverage.lcovReportPath", "coverage/lcov.info" property "sonar.ts.tslintconfigPath", "tslint.json" property "sonar.ts.tslintpath", "node_modules/tslint/bin/tslint" property "sonar.ts.tslintrulesDir", "node_modules/codelyzer"

westwick commented 6 years ago

I am having this same issue. It seems some of the keys changed, for example I got the lcov report to work again by changing to sonar.typescript.lcov.reportPaths=coverage/lcov.info, however I cannot find what sonar.ts.tslintconfigPath has been updated to.

nixel2007 commented 6 years ago

You use a different plugin (official one?)

sebastienbonami commented 6 years ago

Any news on this? I have the same problem.

nixel2007 commented 6 years ago

Check the plugin version an author

sebastienbonami commented 6 years ago

@nixel2007 I'm using version v1.1.0 downloaded here: https://github.com/Pablissimo/SonarTsPlugin/releases.

What is the behavior when there are rules in a Quality Profile on Sonar and also other ones specified in tslint.json? They are concatenated?

sebastienbonami commented 5 years ago

I'm still looking for answers... can somebody help? @damodhar22 @westwick @nixel2007