Add mainipv4 to the DTD

PabloCastellano / libcnml

libcnml is a CNML parser library for Python

GNU General Public License v3.0

4 stars 5 forks source link

Add mainipv4 to the DTD #12

Closed shagi closed 8 years ago

shagi commented 9 years ago

Kaixo!

Added mainipv4 to the DTD to make validateDTDLxml work again

nemesifier commented 8 years ago

@shagi have you noticed the failing tests?

shagi commented 8 years ago

Yes, I tried to update the tests, but it requires too much time...

Forget the pull request for now, I'll send it again with updated tests someday

On 2016 urtarrila 11 12:36:13 CET, Federico Capoano notifications@github.com wrote:

@shagi have you noticed the failing tests?

Reply to this email directly or view it on GitHub: https://github.com/PabloCastellano/libcnml/pull/12#issuecomment-170515545

Sent from my Android device with K-9 Mail. Please excuse my brevity.

PabloCastellano commented 8 years ago

I just did it. Updating the tests was a pain because these zones have grown. We should think about using smaller zones or custom-made cnml files.

https://github.com/PabloCastellano/libcnml/commit/aa62385bfd9c8914b234b7163025226ef7914d0b