search

PabloCastellano / libcnml

libcnml is a CNML parser library for Python
GNU General Public License v3.0
4 stars 5 forks source link

Errors in test #18

Open Germano0 opened 8 years ago

Germano0 commented 8 years ago

Hi, I submitted python-libcnml for Review Process in order to push it into Fedora, Fedora EPEL repositories. On my machine the packaging process works correctly, but on Fedora Koji build system (that does not allow the package to connect to internet) fails. I attach here some error message in case you can help me find the problem. Thank you for your time

https://kojipkgs.fedoraproject.org//work/tasks/512/12690512/build.log

PabloCastellano commented 8 years ago

There is one particular test that tests parsing a CNML file from an URL (see https://github.com/PabloCastellano/libcnml/blob/master/libcnml/tests/test_libcnml.py#L148).

I'm not sure about what should we do in this case. What do you think @nemesisdesign ?

Fale commented 8 years ago

Hi, Does it make sense to test with an external url? What are the cases in which the local file succeed while the external fails, since this library is about parsing and not networking?

nemesifier commented 8 years ago

The test request can be mocked (simulated). We introduced this feature to facilitate integration with netdiff and django-netjsongraph, so I'd prefer to keep it.

PabloCastellano commented 8 years ago

@nemesisdesign Mocking sounds good to me too.

PRs are welcome!