search

PabloCastellano / libcnml

libcnml is a CNML parser library for Python
GNU General Public License v3.0
4 stars 5 forks source link

Commits for issues #7 and #8 #9

Closed emmdim closed 8 years ago

emmdim commented 9 years ago

Check them before accept.

emmdim commented 9 years ago

Last commit fails the test. The issue is that following the CNML structure CNMLInterface is not necesarily the child of a CNMLRadio but can also be a child of a CNMLDevice as well. While the parsing is done correctly the attribute parentRadio for CNMLInterface object is misleading.

emmdim commented 9 years ago

@PabloCastellano any comment?

nemesifier commented 8 years ago

@emmdim I think the tests need to be updated, this change should go in a new release (likely 0.10) indicating there's a backward incompatible change in the changelog.

emmdim commented 8 years ago

@nemesisdesign @PabloCastellano Ok. In general I have a variety of commits that can be added. Some make the library more compatible with guifi CNML some are generic. Here you can see all of them: https://github.com/emmdim/guifiAnalyzer/commits/master/lib/libcnml

The most important is (already based on my version of libcnml though): https://github.com/emmdim/guifiAnalyzer/commit/51a5d6be98e9799521cc51dde80515861d981d0f#diff-ccf834792b38a4dcacd8228ba741928d

itorres commented 8 years ago

@PabloCastellano shouldn't this PR be closed since you fixed the issues in other commits?

PabloCastellano commented 8 years ago

You're right. Closing.