search

PabloLION / xterm-react

React component for xterm.js terminal integration
https://www.npmjs.com/package/@pablo-lion/xterm-react
MIT License
6 stars 0 forks source link

Xterm not working #29

Closed mohsenomidi closed 1 month ago

mohsenomidi commented 1 month ago

Dear @PabloLION ,

Based on Documentation the simple minimum component not working, would you provide the working example Also the import should be changed to import { XTerm } from "@pablo-lion/xterm-react";

Thanks

PabloLION commented 1 month ago

yea right. I totally missed that because I was going to name the package "xterm-react". Thanks for the notice!

mohsenomidi commented 1 month ago

Thanks, also with this change the provided example not working

PabloLION commented 1 month ago

Yes, I checked yesterday and found the problem lies in the lifecycle of the XTerm component. In my initial test case, I only evaluated the use case without strict mode.

I have now added a test case that wraps the component in strict mode tags, and I am addressing the issue.

There are additional missing cases, such as handling multiple instances and input capabilities. I will add these later.

mohsenomidi commented 1 month ago

Sounds great, thanks

PabloLION commented 1 month ago

solved by

PabloLION commented 1 month ago

@mohsenomidi can you check https://replit.com/@PabloLION/XTerm-React?v=1 and see if this is what you wanted?

mohsenomidi commented 3 weeks ago

Thanks, It's okay now Sorry for late response