search

PabloMK7 / citra

A Nintendo 3DS Emulator
GNU General Public License v2.0
3.76k stars 637 forks source link

Add "Steps per hour" system setting #211

Closed szdarkhack closed 3 months ago

szdarkhack commented 4 months ago

This implements a "Steps per hour" system setting to be returned from PTM:GetStepHistory, as described in issue #208.

Currently the setting is global (i.e. not per-game).

PabloMK7 commented 4 months ago

Can you send screenshot of the new UI? Also, would you be able to add the setting to android?

szdarkhack commented 4 months ago

The UI is shown below. I've tried my best to maintain the existing style and made sure it doesn't show in the per-game config.

image

I don't think I'll be able to do the Android UI, at least not for now, but I can try it when I get some spare time again. Also I tried to make the setting work per-game but failed, I certainly intend to take another crack at that at some point (if noone beats me to it).

Any suggestions for improving the setting label or any such detail are of course welcome. Maybe "Pedometer steps per hour" would be clearer?

szdarkhack commented 4 months ago

Terribly sorry, I just realized I had the wrong author set so I had to amend and force push.

szdarkhack commented 3 months ago

I've made the requested changes and tested that the ini value is properly loaded (and works as intended) for both the SDL frontend and the android version.