Some ffmpeg DLLs aren't included in the windows release? (avfilter-9.dll + postproc-57.dll)

DimitriPilot3 commented 1 month ago

Issue

[x] I have searched the existing issues

Affected Build(s)

r608383e (msvc and msys2)

Description of the issue

The release builds provided for citra-windows-msvc and citra-windows-msys2 appear to be missing some shared DLLs that are needed for the video dumping feature:

msvc ships with ffmpeg 6.1.x libraries but is missing avfilter-9.dll and postproc-57.dll;
msys2 ships with ffmpeg 7.x libraries, which is not the version that Citra expects (refer to #249 and #248). Even if it were the case, both avfilter-10.dll and postproc-58.dll are missing.

Reproduction Steps

Download the affected build(s) from the release page
Run citra-qt
Menu > Tools > Dump video

Expected: A dialog appears, you can decide the format, video, and audio encode options

Actual: FFmpeg could not be loaded

Log file

[2161.556650] Common common/dynamic_library/ffmpeg.cpp:LoadAVUtil:132: Could not dynamically load libavutil: The specified module cannot be found.

(If avfilter-9.dll exists but postproc-57.dll is missing, the log output is the same.)

System configuration

OS: Windows 10 22H2

Workaround

Download ffmpeg 6 shared libraries from gyan.dev (6.1.1) or BtbN (latest 6.1)
Extract the bin directory somewhere
Open Citra, Menu > Tools > Dump video. Select the bin directory when prompted. If it failed to install (likely because it can't overwrite DLLs that are in use by Citra), close Citra, and copy all .dll files from the bin directory into the Citra directory, overwriting existing files.
Open Citra, Menu > Tools > Dump video
???
Profit?

After doing this, it seems to load and record successfully ~but not everything works. The best I got was an output file that only contained audio but no video.~ (EDIT: that was with Vulkan—OpenGL works fine!) but occasionally I get a deadlock when emulation stops.

rtiangha commented 1 month ago

Are you using Vulkan? The video dumping only seems to work with OpenGL (unless I'm doing something wrong); Vulkan gets you audio but a black screen.

DimitriPilot3 commented 1 month ago

Oh, you're right! I was using Vulkan and only got audio, but with OpenGL it records audio and video successfully.

PabloMK7 / citra