search

PabloPL / linux

Linux kernel source tree
Other
17 stars 0 forks source link

Split aries dts into galaxys and galaxys4g #2

Closed xc-racer99 closed 6 years ago

xc-racer99 commented 6 years ago

I'm not sure which branch you wanted this based against, but here is the splitting of the dts.

The major differences between my variant and the i9000 are the lack of SDHCI0, no FM radio, and differing hardware buttons. As well, the GPS chipset and the modem differ but that's not important yet.

Apparently the pinctrl changes that I thought were necessary for the SD card aren't, I must have messed something up when I was testing earlier.

PabloPL commented 6 years ago

Since fm and sdhci0 is not present/used on galaxy s 4g, i think it would be better to not include them in common dtsi.

I've made similar/the same split of my aries dts, with this issue fixed and now it's on for-upstream/aries-minimal branch now. Could You rebase changes to that branch (so now You would need to simply add dts for galaxys4g) ?

I'll later remote first three patches, when i got uboot working on galaxys (since without first patch for bootloader, kernel is not booting for me). I'll also update latest patch (which updates documentation with name of galaxys4g board).

Thanks and i hope for more patches :)

PS: If have any questions, maybe better use email/gtalk.

PabloPL commented 6 years ago

I wonder if there is a way to get know on which device we're booting (so we could have one uboot board which would just load different dtb files or even overlays).

xc-racer99 commented 6 years ago

What does https://github.com/xc-racer99/u-boot-galaxys4g/blob/v2018.05-galaxys4g/board/samsung/galaxys4g/galaxys4g.c#L26 return on your device? It's 0xf on my device, on another carrier variant it's 0xd, but I'm not sure if there's a unique number for all the variants or not

PabloPL commented 6 years ago

It looks like it's returning 0xE (didn't found other way to get this than adding printf in checkboard).

Edit 1: Now i see that printenv dumps this info.

board_rev=e

xc-racer99 commented 6 years ago

The get_board_rev function is called when setting up ATAGs as well.

Note that I've renamed the binding to fascinate4g as that's what I technically have. The only difference between the two variants is the GPS chipset.

I think (from my point of view) that this is ready now.

PabloPL commented 6 years ago

I think aries is code name for i9000, but for now i think i'll leave it as it is. Now i'll focus on getting uboot running (i want it to be able to load /boot/boot.scr from sdcard (so if i want to change cmdline params i don't have to mess with uboot).

xc-racer99 commented 6 years ago

I've always thought that aries was the codename for all the first-gen Galaxy S devices based on S5PV210 - at least this is my understanding from the stock Samsung kernel drop and how CyanogenMod named things.