search

PabloPL / linux

Linux kernel source tree
Other
17 stars 0 forks source link

Submit touchkey driver #8

Closed PabloPL closed 5 years ago

xc-racer99 commented 6 years ago

@fourkbomb What's the status of https://github.com/fourkbomb/linux/commit/524442d47c88d5c25a167eaae65aaa0ad31df051 with regards to mainline? I'm using it as a stepping stone to add support for aries (first-gen Galaxy S devices). Thanks!

@PabloPL Would you mind testing https://github.com/PabloPL/linux/commits/for-upstream/touchkey on the i9000? It's working to my satisfaction here.

PabloPL commented 6 years ago

Works fine for me (after adding CONFIG_REGULATOR_FIXED_VOLTAGE and CONFIG_KEYBOARD_TM2_TOUCHKEY).

You can add my "Tested-by" (like it's done for example https://patchwork.kernel.org/patch/10354345/)

fourkbomb commented 6 years ago

Feel free to submit it upstream (and CC me). I doubt I'll get a chance to do it myself in the near future.

PabloPL commented 5 years ago

Patches fixed (there needs to be separate patches for adding documentation and making changes in driver - it shouldn't be in one patch), added missing comments etc and send to upstream for review.

PabloPL commented 5 years ago

@fourkbomb Do You accept dropping name from touchkey_variant struct (like it was mentioned in mailing list)? I could make this change, since i want to submit new version upstream.

PabloPL commented 5 years ago

Droped name change from patches and send new version for review.

PabloPL commented 5 years ago

Accepted in mainline.