search

PabloRomanH / zhongzhong

Chrome extension that translates Chinese words when hovering on them.
https://chrome.google.com/webstore/detail/zhongzhong-an-improved-ch/dggcgdjndddfmcfoipccicfoajmciacf
34 stars 14 forks source link

Zhuyin corrections #19

Closed andrewgilbert12 closed 7 years ago

andrewgilbert12 commented 7 years ago

Added Zhuyin transcriptions for L, N consonants with u: vowel clusters, fixed Zhuyin transcription for lun, luo, nuo

PabloRomanH commented 7 years ago

hi @andrewgilbert12 thanks for the commit! it's great to see that there is interest in improving this extension. I don't know anything about Zhuying so it's great that you could help to fix it.

I just found one line that I think you forgot to add or removed accidentally. I'll merge and publish a new version of the extension as soon as you can confirm that.

BTW, did you check all the Zhuyin conversion map for mistakes? Should I check everything to make sure there are no more mistakes?

Thanks!

andrewgilbert12 commented 7 years ago

Pablo,

Yes, it looks like I accidentally deleted the 'nun' conversion! I didn't check the entire mapping yet, I will do that in the next day or so and push another request (can squash if you want) if I notice more mistakes.

andrewgilbert12 commented 7 years ago

Hello again!

I checked the Zhuyin chart and it looks like everything is ok now.

Best, Andrew