search

PabloRomanH / zhongzhong

Chrome extension that translates Chinese words when hovering on them.
https://chrome.google.com/webstore/detail/zhongzhong-an-improved-ch/dggcgdjndddfmcfoipccicfoajmciacf
34 stars 14 forks source link

Fix taiwan voice setting #28

Closed wernersa closed 6 years ago

wernersa commented 6 years ago

The settings page does not correctly show when stored voice is Taiwan, and will change font setting when stored voice is Taiwan.

PabloRomanH commented 6 years ago

Thanks for the contribution! I added a fix because you were not setting a default value for the colors, so if the user tried to use the extension without entering the settings page at least once it wouldn't work.

I also added a setting for the neutral tone, since some of the themes were showing a weird color for it.

I'll publish it in the webstore now, so it should be available in a short while.

Thanks!