search

PabloRomanH / zhongzhong

Chrome extension that translates Chinese words when hovering on them.
https://chrome.google.com/webstore/detail/zhongzhong-an-improved-ch/dggcgdjndddfmcfoipccicfoajmciacf
34 stars 14 forks source link

Allow Disabling Skritter Shortcut #43

Closed mcmar closed 4 years ago

mcmar commented 4 years ago

Currently, it's not possible to disable the Skritter shortcut 's'. This is unfortunate as Language Learning with Netflix also uses 's' as the shortcut for repeating a subtitle. Other shortcuts already have options to be enabled/disabled, but 's' has sadly been overlooked.

PabloRomanH commented 4 years ago

Let me take some time this weekend to look at this!

On Mon, Mar 9, 2020 at 11:20 AM Mike Martin notifications@github.com wrote:

Currently, it's not possible to disable the Skritter shortcut 's'. This is unfortunate as Language Learning with Netflix also uses 's' as the shortcut for repeating a subtitle. Other shortcuts already have options to be enabled/disabled, but 's' has sadly been overlooked.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PabloRomanH/zhongzhong/issues/43?email_source=notifications&email_token=AAJMIZ62C4MRY4DLXUFOKQTRGR4DVA5CNFSM4LEAUKD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITOHHLQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMIZ44DBEG2NLBKUKXKXTRGR4DVANCNFSM4LEAUKDQ .

mcmar commented 4 years ago

Thanks @PabloRomanH I already submitted a pull request where I add a disabled option to the existing Skritter domain dropdown and slightly modify the copy to make it clear that you can disable it. If that looks good, then please feel free to merge and deploy when you get the chance. If you'd prefer, I can also easily create a separate checkbox to disable it as well. I figured this was a bit clearer instead of having a checkbox that effectively overrides the Skritter domain.

mcmar commented 4 years ago

Also, I of course tested the pull request in developer mode before and after to ensure that the existing Skritter functionality continues to work 100% as expected.

mcmar commented 4 years ago

Hey @PabloRomanH, would you mind doing a deploy to the Chrome store? It looks like the last update was Dec 2, 2019. Thank you!

PabloRomanH commented 4 years ago

Okay, I've submitted it with the last version of the dictionary. It says that they may take a few days or weeks to review it, though.