Cantonese support

[orientalperil]

Hi Pablo,

I have made a simple experiment to put in Cantonese support to Zhongzhong. If you are open to adding Cantonese then I can continue the implementation and get everything coded. I'm using the data from the CC-Canto project from https://cantonese.org/. At the moment this branch has just the Cedict Cantonese readings not the Cantonese language entries yet. By the way thanks for this extension, it's great!

These are the changes I'm thinking about:

• [ ] if a cantonese reading for cedict doesn't exist print "no cantonese reading"
• [ ] language options to display mandarin or cantonese or both
• [ ] add support for cccanto
• [ ] update index.py to work with cedict and cccanto
• [ ] update index.py to python 3
• [ ] add cantonese to word list output
• [ ] add cantonese tone colors
• [ ] update font to use correct font with cantonese characters
• [ ] add sino-vietnamese readings
• [ ] makefile to build indexes

[orientalperil]

@PabloRomanH Can I get confirmation you are still working on this project?

[PabloRomanH]

Hey! Yes. I'll review this when I have some time.

On Friday, July 31, 2020, Kevin Tran notifications@github.com wrote:

@PabloRomanH https://github.com/PabloRomanH Can I get confirmation you are still working on this project?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PabloRomanH/zhongzhong/pull/47#issuecomment-667212520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMIZ63IKHMXC7ZQNJXXLLR6LWETANCNFSM4PBW3WHA .

-- Pablo Roman Learn Spanish naturally: youtube.com/DreamingSpanish Blog about SLA: dreaminglanguages.com http://dreaminglanguages.wordpress.com/

[orientalperil]

Awesome thank you!

[orientalperil]

@PabloRomanH it seems you are very busy. Would you be ok with making me a committer? I'm happy to lead the development if you are open to having this feature.

Or if you are not interested in having this feature then let me know and I can fork the extension. I just want to get this cleaned up and available in the Chrome Web Store.

[PabloRomanH]

Yeah, sorry about that. I've been really busy moving countries.

I think the best solution would be to fork it into a separate extension. That way we can keep the extension smaller, since most people aren't going to need both languages. That will also allow you to make changes to the extension that are specific for Cantonese, and will allow us to keep a simpler settings page.

On Saturday, August 29, 2020, Kevin Tran notifications@github.com wrote:

@PabloRomanH https://github.com/PabloRomanH it seems you are very busy. Would you be ok with making me a committer? I'm happy to lead the development if you are open to having this feature.

Or if you are not interested in having this feature then let me know and I can fork the extension. I just want to get this cleaned up and available in the Chrome Web Store.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PabloRomanH/zhongzhong/pull/47#issuecomment-683168769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMIZZ66CJBJK242N7QDWTSDATZHANCNFSM4PBW3WHA .

-- Pablo Roman Learn Spanish naturally: youtube.com/DreamingSpanish Blog about SLA: dreaminglanguages.com http://dreaminglanguages.wordpress.com/

[orientalperil]

Ok will do