search

PabloRomanH / zhongzhong

Chrome extension that translates Chinese words when hovering on them.
https://chrome.google.com/webstore/detail/zhongzhong-an-improved-ch/dggcgdjndddfmcfoipccicfoajmciacf
34 stars 14 forks source link

Add Definitions for Redirected Entries #59

Closed kumar-ish closed 1 year ago

kumar-ish commented 1 year ago

[Cross-posting from the Zhongwen github repo so the UI for the popup is different, but I've started using zhongzhong now and the same thing occurs in the zhongzohong UI]

Hi. Occasionally I come across a definition like "嘴硬心軟" (see screenshot) which just redirects to another definition through the extension. I think it would be good to show the redirected definition (perhaps indented under the suggestion to redirect) instead of having to manually find it on another website / on CEDICT. Perhaps this can be optionally enabled as an experiment on one of the extension options, just in case there's any edge cases that we don't consider. I'm happy to code this up and go through the review process as you see fit.

image
PabloRomanH commented 1 year ago

Have you tried it? This should already be working. If it doesn't work with some words then it means there's one more syntax for redirects that we haven't considered and we should add it to the current ones.

2023年7月10日(月) 14:52 kumar-ish @.***>:

[Cross-posting from the Zhongwen github repo, but I've started using zhongzhong now]

Hi. Occasionally I come across a definition like "嘴硬心軟" (see screenshot) which just redirects to another definition through the extension. I think it would be good to show the redirected definition (perhaps indented under the suggestion to redirect) instead of having to manually find it on another website / on CEDICT. Perhaps this can be optionally enabled as an experiment on one of the extension options, just in case there's any edge cases that we don't consider. I'm happy to code this up and go through the review process as you see fit. [image: image] https://user-images.githubusercontent.com/47245900/252261036-9dd17f73-e640-4dc1-bce4-8747d8bed0f2.png

— Reply to this email directly, view it on GitHub https://github.com/PabloRomanH/zhongzhong/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMIZZ4NZVYBRUA2CAUMI3XPOYELANCNFSM6AAAAAA2EESQ2E . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kumar-ish commented 1 year ago

I was being silly, sorry 😓 -- I didn't notice the redirected definition at the bottom. Thank you!