Pacanor / GSB_Project2

Week 3 Project for GSB training
0 stars 0 forks source link

Feature: Added Square Root and Tests #30

Closed MalamaKangwa closed 4 years ago

Pacanor commented 4 years ago

I have reviewed the code you created. I noticed a few issues, as stated below:

  1. Either set your return for the int root function to double or dynamic.

  2. Do not convert the root of an into to an int. Square root of 3 is not 1.

  3. Change int c to double or dynamic, just like the return value.

  4. Replicate the static for double arrays, but for int arrays. But make sure the return is still a double array

The rest looks fine. Please edit or justify each concern and create a new request