search

Pacific-salmon-assess / samSim

3 stars 0 forks source link

adjustment for sigma autocorrelation #26

Closed catarinawor closed 2 years ago

catarinawor commented 2 years ago

I noticed that an adjustment for sigmaR is proposed to account for temporal autocorrelation here I am not super sure, but I think we might be missing a sqrt? i.e. shouldn't it be:

ricSig <- sqrt(ricSig^2 * (1 - rho^2))

?

carrieholt commented 2 years ago

Yes, you're right. However, I don't think any of us have used this code because our models have not included an AR(1) process. But, yes, I think it would be good to correct that. Thanks.

catarinawor commented 2 years ago

You are right! None of the study cases uses this adjustment. I just pushed my suggested change to the LRP branch.