search

Pacific-salmon-assess / samSim

3 stars 0 forks source link

Add safeguard to prevent adding 3 beta errors to catch? #27

Closed catarinawor closed 2 years ago

catarinawor commented 2 years ago

Given the email discussions on the layers of Beta() error on ER, and how it varies between the master and LRP branches, I am wondering if it would be a good idea to add a few lines setting the variables mixOUSig and singOUSig to zero if harvContRule == "fixedER". This would guarantee that we never have the three layers of Beta uncertainty applied by accident.

this change would be implemented here

Let me know what you think -- no rush.

carrieholt commented 2 years ago

Sounds great. Thanks!

catarinawor commented 2 years ago

Done!