search

Pacific-salmon-assess / samSim

3 stars 0 forks source link

ER=1 occurring even when ERmax>1. #30

Closed catarinawor closed 1 year ago

catarinawor commented 1 year ago

Please refer to the timevar branch It seems that in scenarios with high cv for ER, realized ER can sometimes be 1. I implemented the ERmax cap, but it does not seem to be working.

ERmax was implemented in the following functions (and their associated calls in genericRecoverySimulator.R): calcRealCatch.R calcCanEROU_fixedER.R

I'll work on a isolated script the reproduces this behavior, but it can also be found in scenario 4 of SimER.R. - i.e. set a=4.

catarinawor commented 1 year ago

Fixed by implementing maxER in function calcTAC_fixedER()