PacificBiosciences / kineticsTools

Tools for detecting DNA modifications from single molecule, real-time sequencing data
21 stars 21 forks source link

Is replaceScipyNormPdf in MixtureEstimationMethods.py correct? #91

Open ZhangBio opened 2 years ago

ZhangBio commented 2 years ago

At https://github.com/PacificBiosciences/kineticsTools/blob/master/kineticsTools/MixtureEstimationMethods.py#L86. capture

From the name of this function, it seems to be designed as a substitute of the scipy.stats.norm.pdf() and return the probablity of data under normal distribution (mu,1).
But it's easy to tell that the maximum value is not at "mu" (when mu is set), but is at "-inf". Does this function perform what it's supposed to do? Or I misunderstood something?